[PATCH] D110016: Check for invalid projects passed in LLVM_ENABLE_PROJECTS

Mon Sep 20 11:45:21 PDT 2021

mehdi_amini added a comment.

In D110016#3010053 <https://reviews.llvm.org/D110016#3010053>, @thakis wrote:

> This is a problem for us (chromium). We inject an extra target at the cmake level and then pass that to LLVM_ENABLE_PROJECTS. That used to work fine, but now it's rejected.

I didn't quite get the "inject" part?

> How should we proceed?
>
> - Put this check behind a (default-on) option and turn it off for us
> - Add a setting of valid extra project names that's default-empty

Any of these could work.

> - Your idea here

Actually we already have a flag for that: `-DLLVM_EXTERNAL_PROJECTS` which is intended to be used to declare projects that aren't "known" (see https://llvm.org/docs/CMake.html )
Aren't you able to use this?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110016/new/

https://reviews.llvm.org/D110016