[PATCH] D110055: [AsmPrinter] Loop over bundles in generic code

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne updated this revision to Diff 373529.
sebastian-ne marked an inline comment as done.
sebastian-ne added a comment.

Good idea to use `.instrs()`, it looks better now.

> I guess if you re-auto-generated test checks, there would be millions of changes due to extra comments at the end of lines? But they don't show up as failures because the generated checks don't end with `{{$}}`?

Right, they don’t show up as failures. I hope it wouldn’t be millions, the comment is only new for spills inside bundles/clauses. I can search for such cases and regenerate the tests if you think it makes sense?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110055/new/

https://reviews.llvm.org/D110055

Files:
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/Target/AMDGPU/AMDGPUMCInstLower.cpp
  llvm/lib/Target/Hexagon/HexagonAsmPrinter.cpp
  llvm/lib/Target/Lanai/LanaiAsmPrinter.cpp
  llvm/lib/Target/Mips/MipsAsmPrinter.cpp
  llvm/lib/Target/Sparc/SparcAsmPrinter.cpp
  llvm/lib/Target/VE/VEAsmPrinter.cpp
  llvm/test/CodeGen/AMDGPU/vgpr-tuple-allocation.ll
  llvm/test/CodeGen/Hexagon/hvx-reuse-fi-base.ll
  llvm/test/DebugInfo/Mips/dbg-call-site-low-pc.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D110055.373529.patch
Type: text/x-patch
Size: 17176 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210920/b475afd2/attachment.bin>