[PATCH] D110055: [AsmPrinter] Loop over bundles in generic code

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 20 02:38:37 PDT 2021


foad added a comment.

I guess if you re-auto-generated test checks, there would be millions of changes due to extra comments at the end of lines? But they don't show up as failures because the generated checks don't end with `{{$}}`?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1275
     DenseMap<StringRef, unsigned> MnemonicCounts;
     for (auto &MI : MBB) {
+      MachineBasicBlock::const_instr_iterator I = MI.getIterator();
----------------
Can't you change this loop to iterate over MBB.instrs(), instead of adding another nested loop?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110055/new/

https://reviews.llvm.org/D110055



More information about the llvm-commits mailing list