[PATCH] D110055: [AsmPrinter] Loop over bundles in generic code

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 20 03:00:40 PDT 2021


foad added a comment.

> I can search for such cases and regenerate the tests if you think it makes sense?

I think it would be nice, to avoid spurious changes the next time someone has to regenerate the checks, but I won't insist.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1275
     DenseMap<StringRef, unsigned> MnemonicCounts;
-    for (auto &MI : MBB) {
+    for (auto &MI : MBB.instrs()) {
       // Print the assembly for the instruction.
----------------
Much nicer! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110055/new/

https://reviews.llvm.org/D110055



More information about the llvm-commits mailing list