[PATCH] D109700: [InstCombine] Improve TryToSinkInstruction with multiple uses

Wed Sep 15 12:55:15 PDT 2021

anna added a comment.

In D109700#3002240 <https://reviews.llvm.org/D109700#3002240>, @lebedev.ri wrote:

> In D109700#2997743 <https://reviews.llvm.org/D109700#2997743>, @anna wrote:
>
>> In D109700#2997739 <https://reviews.llvm.org/D109700#2997739>, @lebedev.ri wrote:
>>
>>> Please split the rename into a preparatory change
>>
>> I don't follow. This is not a rename. It is an API change where we return a unique *User* instead of a use.
>
> Please disregard. My actual question was intended to be more along the lines of:
> "do we actually want to completely replace that API like this",
> but i'm not really seeing a reason not to.

Ah. Yes, I went through the same process when deciding to replace the original API :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109700/new/

https://reviews.llvm.org/D109700