[PATCH] D109700: [InstCombine] Improve TryToSinkInstruction with multiple uses

[Anna Thomas via Phabricator via llvm-commits]

anna added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:3834
+            // sophisticed analysis (i.e finding NearestCommonDominator of these
+            // use blocks).
+            if (UserParent)
----------------
nikic wrote:
> anna wrote:
> > mkazantsev wrote:
> > > Can we at least allow it if they come from same block? It's typical for switches.
> > yes, will do. 
> The "more than one use" comment isn't quite accurate anymore.
Good point, will update comment before landing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109700/new/

https://reviews.llvm.org/D109700