[PATCH] D109700: [InstCombine] Improve TryToSinkInstruction with multiple uses

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:3834
+            // sophisticed analysis (i.e finding NearestCommonDominator of these
+            // use blocks).
+            if (UserParent)
----------------
anna wrote:
> mkazantsev wrote:
> > Can we at least allow it if they come from same block? It's typical for switches.
> yes, will do. 
The "more than one use" comment isn't quite accurate anymore.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109700/new/

https://reviews.llvm.org/D109700