[PATCH] D109700: [InstCombine] Improve TryToSinkInstruction with multiple uses
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 15 11:49:28 PDT 2021
lebedev.ri added a comment.
In D109700#2997743 <https://reviews.llvm.org/D109700#2997743>, @anna wrote:
> In D109700#2997739 <https://reviews.llvm.org/D109700#2997739>, @lebedev.ri wrote:
>
>> Please split the rename into a preparatory change
>
> I don't follow. This is not a rename. It is an API change where we return a unique *User* instead of a use.
Please disregard. My actual question was intended to be more along the lines of:
"do we actually want to completely replace that API like this",
but i'm not really seeing a reason not to.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109700/new/
https://reviews.llvm.org/D109700
More information about the llvm-commits
mailing list