[PATCH] D109587: [RISCV][WIP] Generate target attribute in attribute section of object file when assemble .s file

Fri Sep 10 03:18:49 PDT 2021

jrtc27 added a comment.

Please upload patches using full context; see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface (or the section above it; `arc diff` does everything for you).

Whilst we should be emitting attributes for hand-written assembly files for anything not explicitly specified, that should only be done for the top-level file, not for inline assembly.

================
Comment at: llvm/test/MC/RISCV/rvf-user-csr-names.s:6
 # RUN:     | FileCheck -check-prefix=CHECK-INST-ALIAS %s
-# RUN: llvm-mc -filetype=obj -triple riscv32 -mattr=+f < %s \
+# RUN: llvm-mc -filetype=obj -triple riscv32  < %s \
 # RUN:     | llvm-objdump -d - \
----------------
So, this used to be required until D58932. I guess it's fine to remove it from the llvm-mc invocation (though this one fails to delete one of the spaces); the alternative would be to add `--mattr=-f` to the `llvm-objdump` invocation, but I think this diff makes more sense.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109587/new/

https://reviews.llvm.org/D109587