[PATCH] D109587: [RISCV][WIP] Generate target attribute in attribute section of object file when assemble .s file

[Zixuan Wu via Phabricator via llvm-commits]

zixuan-wu added a comment.

In D109587#2994117 <https://reviews.llvm.org/D109587#2994117>, @jrtc27 wrote:

> Please upload patches using full context; see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface (or the section above it; `arc diff` does everything for you).
>
> Whilst we should be emitting attributes for hand-written assembly files for anything not explicitly specified, that should only be done for the top-level file, not for inline assembly.

You mean when the asm parser is constructed only for inline-asm, then do not generate attributes instead of other code path invocation ? Is there any predict/judgement can be used in asm parser constructor to see whether it's in inline-asm code path?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109587/new/

https://reviews.llvm.org/D109587