[PATCH] D108984: [WebAssembly][libObject] Avoid re-use of Section object during parsing

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

I guess another option on the test would be to just keep the same sections that are in this test now, but still add `foo` at the front. The existing tests can stay the same and we could add one that covers this case (or we could switch one of the existing tests to use foo instead of producers if that would cover both cases, so we don't need to increase the total number of tests).



================
Comment at: llvm/test/tools/llvm-objcopy/wasm/basic-only-section.test:17
 # CHECK-NEXT:   - Type: CUSTOM
-# CHECK-NEXT:     Name: producers
-# CHECK-NEXT:     Tools:
+# CHECK-NEXT:     Name: foo
+# CHECK-NEXT:     Payload: DEADBEEF
----------------
The intent here was to test that the known sections are gone (because the custom section was after the known sections). But now it doesn't test that, because the custom section is after the known sections.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108984/new/

https://reviews.llvm.org/D108984