[PATCH] D108984: [WebAssembly][libObject] Avoid re-use of Section object during parsing
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 31 12:27:33 PDT 2021
sbc100 added inline comments.
================
Comment at: llvm/test/tools/llvm-objcopy/wasm/basic-only-section.test:17
# CHECK-NEXT: - Type: CUSTOM
-# CHECK-NEXT: Name: producers
-# CHECK-NEXT: Tools:
+# CHECK-NEXT: Name: foo
+# CHECK-NEXT: Payload: DEADBEEF
----------------
dschuff wrote:
> The intent here was to test that the known sections are gone (because the custom section was after the known sections). But now it doesn't test that, because the custom section is after the known sections.
Oh in that case I can just `CHECK-NEXT: ...` to ensure this is the one and only section. That seems strictly more clear.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108984/new/
https://reviews.llvm.org/D108984
More information about the llvm-commits
mailing list