[PATCH] D108984: [WebAssembly][libObject] Avoid re-use of Section object during parsing

Tue Aug 31 04:37:29 PDT 2021

sbc100 added a comment.

In D108984#2974366 <https://reviews.llvm.org/D108984#2974366>, @jhenderson wrote:

> The test has changed quite a bit more than I'd expect. What's the reasoning behind that?

This change means that the this test acts a regression test for the bug.   In order for the bug to show itself we have to put a custom section before a builtin section.     This is because only custom sections have names and the bug is that the Name field from a custom section was getting applied to all builtin sections that follow it.

If you prefer I can leave this test as is but write a specific regression test in `llvm/test/Object` instead?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108984/new/

https://reviews.llvm.org/D108984