[PATCH] D108727: [X86][MCA] Address other issues with MULX reported in PR51495.
Andrea Di Biagio via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 25 15:00:42 PDT 2021
andreadb added a comment.
In D108727#2966053 <https://reviews.llvm.org/D108727#2966053>, @lebedev.ri wrote:
> In D108727#2966046 <https://reviews.llvm.org/D108727#2966046>, @andreadb wrote:
>
>> In D108727#2965965 <https://reviews.llvm.org/D108727#2965965>, @lebedev.ri wrote:
>>
>>> I think we should rename `WriteIMulH`/`WriteIMulH` to better convey that it is for the low half of the multiplicative result.
>>
>> So, rather than swapping the position of the two writes, you suggest to rename `WriteIMulH` into something like `WriteIMulLo`?
>
> No, i mean in addition to the current diff, also rename the `WriteIMulH`.
With this patch, WriteIMulH now correctly references the high half.
If you think that the name should be changed then what name do you suggest to use?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108727/new/
https://reviews.llvm.org/D108727
More information about the llvm-commits
mailing list