[PATCH] D108727: [X86][MCA] Address other issues with MULX reported in PR51495.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

In D108727#2966067 <https://reviews.llvm.org/D108727#2966067>, @andreadb wrote:

> In D108727#2966053 <https://reviews.llvm.org/D108727#2966053>, @lebedev.ri wrote:
>
>> In D108727#2966046 <https://reviews.llvm.org/D108727#2966046>, @andreadb wrote:
>>
>>> In D108727#2965965 <https://reviews.llvm.org/D108727#2965965>, @lebedev.ri wrote:
>>>
>>>> I think we should rename `WriteIMulH`/`WriteIMulH` to better convey that it is for the low half of the multiplicative result.
>>>
>>> So, rather than swapping the position of the two writes, you suggest to rename `WriteIMulH` into something like `WriteIMulLo`?
>>
>> No, i mean in addition to the current diff, also rename the `WriteIMulH`.
>
> With this patch, WriteIMulH now correctly references the high half.
>
> If you think that the name should be changed then what name do you suggest to use?

Ah, hmm, i think i got fooled by overrides in znver3 model.
Looking at this again, i believe this is correct as-is.
I will fix Zen3 model afterwards.

LG
@RKSimon ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108727/new/

https://reviews.llvm.org/D108727