[PATCH] D108727: [X86][MCA] Address other issues with MULX reported in PR51495.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 25 14:50:38 PDT 2021


lebedev.ri added a comment.

In D108727#2966046 <https://reviews.llvm.org/D108727#2966046>, @andreadb wrote:

> In D108727#2965965 <https://reviews.llvm.org/D108727#2965965>, @lebedev.ri wrote:
>
>> I think we should rename `WriteIMulH`/`WriteIMulH` to better convey that it is for the low half of the multiplicative result.
>
> So, rather than swapping the position of the two writes, you suggest to rename `WriteIMulH` into something like `WriteIMulLo`?

No, i mean in addition to the current diff, also rename the `WriteIMulH`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108727/new/

https://reviews.llvm.org/D108727



More information about the llvm-commits mailing list