[PATCH] D108727: [X86][MCA] Address other issues with MULX reported in PR51495.

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

In D108727#2965965 <https://reviews.llvm.org/D108727#2965965>, @lebedev.ri wrote:

> I think we should rename `WriteIMulH`/`WriteIMulH` to better convey that it is for the low half of the multiplicative result.

So, rather than swapping the position of the two writes, you suggest to rename `WriteIMulH` into something like `WriteIMulLo`?



================
Comment at: llvm/lib/MCA/HardwareUnits/RegisterFile.cpp:293
+    // instruction to register RegID.
+    const WriteRef &OtherWrite = RegISterMappings[RegID].first;
+    const WriteState *OtherWS = OtherWrite.getWriteState();
----------------
lebedev.ri wrote:
> This doesn't compile for me
> ```
> /repositories/llvm-project/llvm/lib/MCA/HardwareUnits/RegisterFile.cpp:293:34: error: use of undeclared identifier 'RegISterMappings'; did you mean 'RegisterMappings'?
>     const WriteRef &OtherWrite = RegISterMappings[RegID].first;
>                                  ^~~~~~~~~~~~~~~~
>                                  RegisterMappings
> /repositories/llvm-project/llvm/include/llvm/MCA/HardwareUnits/RegisterFile.h:190:32: note: 'RegisterMappings' declared here
>   std::vector<RegisterMapping> RegisterMappings;
>                                ^
> 
> ```
I will fix it. Sorry.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108727/new/

https://reviews.llvm.org/D108727