[PATCH] D108513: [docs] Update Getting Started with Visual Studio guide

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth added a comment.

I also thank you for working to improve this documentation.  I mostly agree the other reviewer.  I've only added a couple inline comments to raise questions.  I wouldn't hold this back for either of those.



================
Comment at: llvm/docs/GettingStartedVS.rst:55
-<http://www.python.org/>`_. Version 3.6 and newer are known to work. You will
-need `GnuWin32 <http://gnuwin32.sourceforge.net/>`_ tools, too.
 
----------------
aaron.ballman wrote:
> I'm a bit worried about losing this information; I didn't have luck skipping GnuWin32 the last time I tried (about a year ago), so I don't think just Python is sufficient. WDYT?
The git-provided versions of common unix tools have been sufficient for me (except there's no make in git).  The git ones are also newer than the GnuWin32 ones, and a couple of them behave slightly differently.

The only reason I still I install GnuWin32 is because lldb tests require make.  That said, I make sure that GnuWin32 comes _after_ git in my PATH.  Otherwise, other things go wrong.  GnuWin32 is old and unmaintained.  I don't think we can expect Windows developers to continue to rely on it.

I'm not against mentioning it as a possibility, but I don't think it belongs in the mainline "Getting Started" recommendations.


================
Comment at: llvm/docs/GettingStartedVS.rst:114
 
-      1. ``cd <where-you-want-llvm-to-live>``
-      2. ``git clone https://github.com/llvm/llvm-project.git llvm``
-      3. ``cd llvm``
+       cmake -S llvm\llvm -B build -DLLVM_ENABLE_PROJECTS=clang -DLLVM_TARGETS_TO_BUILD=X86 -Thost=x64
+       exit
----------------
kuhnel wrote:
> I'm not familiar with using CMake with the Visual Studio build system, but don't you need to set the output build system with `cmake -G "Visual Studio 17 2022`? Or is that set automatically?
That's an interesting question.  I've never actually built from the Visual Studio IDE.  I use CMake to generate solution and project files for browsing, editing, and debugging.  But I also have CMake generate a ninja solution and actually build from the command line.  In both cases, I explicitly specify the generator.  If we're not recommending ninja for builds, then maybe we don't need to mention how to install it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108513/new/

https://reviews.llvm.org/D108513