[PATCH] D108513: [docs] Update Getting Started with Visual Studio guide

Mon Aug 23 23:53:13 PDT 2021

mstorsjo added inline comments.

================
Comment at: llvm/docs/GettingStartedVS.rst:55
-<http://www.python.org/>`_. Version 3.6 and newer are known to work. You will
-need `GnuWin32 <http://gnuwin32.sourceforge.net/>`_ tools, too.

----------------
amccarth wrote:
> aaron.ballman wrote:
> > I'm a bit worried about losing this information; I didn't have luck skipping GnuWin32 the last time I tried (about a year ago), so I don't think just Python is sufficient. WDYT?
> The git-provided versions of common unix tools have been sufficient for me (except there's no make in git).  The git ones are also newer than the GnuWin32 ones, and a couple of them behave slightly differently.
> 
> The only reason I still I install GnuWin32 is because lldb tests require make.  That said, I make sure that GnuWin32 comes _after_ git in my PATH.  Otherwise, other things go wrong.  GnuWin32 is old and unmaintained.  I don't think we can expect Windows developers to continue to rely on it.
> 
> I'm not against mentioning it as a possibility, but I don't think it belongs in the mainline "Getting Started" recommendations.
Also FYI, regarding GnuWin32 vs the git unix tools - the llvm lit tests also have a provision where they try to locate the git unix tools and add them to the path, but this isn't hooked up when running other testsuites (like for libcxx). See https://github.com/llvm/llvm-project/blob/main/llvm/utils/lit/lit/llvm/config.py#L29-L35.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108513/new/

https://reviews.llvm.org/D108513