[PATCH] D108513: [docs] Update Getting Started with Visual Studio guide

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added inline comments.


================
Comment at: llvm/docs/GettingStartedVS.rst:43
+Object files, libraries and executables consume approximately 5GB in
+Release mode and much more in Debug mode. SSD drive is recommended.
+
----------------
If we're going to recommend hardware, should we also recommend a significant amount of RAM?


================
Comment at: llvm/docs/GettingStartedVS.rst:55
-<http://www.python.org/>`_. Version 3.6 and newer are known to work. You will
-need `GnuWin32 <http://gnuwin32.sourceforge.net/>`_ tools, too.
 
----------------
I'm a bit worried about losing this information; I didn't have luck skipping GnuWin32 the last time I tried (about a year ago), so I don't think just Python is sufficient. WDYT?


================
Comment at: llvm/docs/GettingStartedVS.rst:58
+install Python with Visual Studio 2019, from the Microsoft store or from
+the `Python web site <http://www.python.org/>`_. We recommend the later since it
+allows you to to adjust installation options.
----------------



================
Comment at: llvm/docs/GettingStartedVS.rst:110
 
-   * With git access:
+11. Finally, configure LLVM using CMake:
 
----------------
kuhnel wrote:
> Nit: Maybe call out, that you're only building clang here and users need to configure the other projects as needed, e.g. as explained in https://llvm.org/docs/CMake.html#frequently-used-llvm-related-variables
Before getting to "finally", should we explain what needs installation for tests to work (like GnuWin32)?


================
Comment at: llvm/docs/GettingStartedVS.rst:250
 
-      C:\..> clang -c hello.c -emit-llvm -o hello.bc
+      c:\..> clang -c hello.c -emit-llvm -o hello.bc
 
----------------
Not certain why we need to churn these examples (FWIW, capital drive letters are still quite common).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108513/new/

https://reviews.llvm.org/D108513