[PATCH] D108519: [DWARFLinker] Prefix debug section names with '.' in the comments. NFC.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D108519#2959080 <https://reviews.llvm.org/D108519#2959080>, @avl wrote:

> I think it would be better to not add any prefixes to section names. On Darwin, section names have "__" prefix. So using "." looks a bit incompatible. It seems, it is better always use section names without prefixes.

Given the DWARF spec talks about the names in the ELF form (with the leading dot) and various other parts of LLVM do this - including messages in llvm-dwarfdump --verify, for instance - I think it's probably not bad to standardize on the dot forms when referring to these names. (the MachO forms also get abbreviated in some places, which would get a bit more weird).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108519/new/

https://reviews.llvm.org/D108519