[PATCH] D108519: [DWARFLinker] Prefix debug section names with '.' in the comments. NFC.
Venkata Ramanaiah Nalamothu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 22 10:46:38 PDT 2021
RamNalamothu added a comment.
In D108519#2959080 <https://reviews.llvm.org/D108519#2959080>, @avl wrote:
> I think it would be better to not add any prefixes to section names. On Darwin, section names have "__" prefix. So using "." looks a bit incompatible. It seems, it is better always use section names without prefixes.
But this file implements DWARF support and the DWARF spec specified section names are prefixed with '.'.
In any case, I think the comments can be consistent in all the places on whether or not prefix debug section names with '.'.
Currently section names prefixed with '.' in some places and not prefixed with '.' in the rest.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108519/new/
https://reviews.llvm.org/D108519
More information about the llvm-commits
mailing list