[PATCH] D108519: [DWARFLinker] Prefix debug section names with '.' in the comments. NFC.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 22 23:17:21 PDT 2021


avl added a comment.

In D108519#2959097 <https://reviews.llvm.org/D108519#2959097>, @RamNalamothu wrote:

> In D108519#2959080 <https://reviews.llvm.org/D108519#2959080>, @avl wrote:
>
>> I think it would be better to not add any prefixes to section names. On Darwin, section names have "__" prefix. So using "." looks a bit incompatible. It seems, it is better always use section names without prefixes.
>
> But this file implements DWARF support and the DWARF spec specified section names are prefixed with '.'.
>
> In any case, I think the comments can be consistent in all the places on whether or not prefix debug section names with '.'.
> Currently section names prefixed with '.' in some places and not prefixed with '.' in the rest.

Right. Comments need to be consistent in all places. Avoiding prefixes would make names looking good for all platforms. But if the idea is to be conformant with Dwarf spec and others prefer dot form I am OK with it also.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108519/new/

https://reviews.llvm.org/D108519



More information about the llvm-commits mailing list