[PATCH] D108472: [test] Update some test cases to use -passes when specifying the pipeline

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 20 09:23:21 PDT 2021 

bjope created this revision.
Herald added subscribers: ormris, kerbowa, arphaman, nhaehnle, jvesely.
bjope requested review of this revision.
Herald added a project: LLVM.

This updates transform test cases for

  ADCE
  AddDiscriminators
  AggressiveInstCombine
  AlignmentFromAssumptions
  ArgumentPromotion
  BDCE
  CalledValuePropagation
  DCE
  Reg2Mem
  WholeProgramDevirt

to use the -passes syntax when specifying the pipeline.

Given that ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER is set to TRUE
the updated test cases already used the new pass manager, but they
were using the backwards compatibility hack to allow the legacy
syntax when specifying the passes to run. This patch can be seen as
a step toward deprecating that interface.

This patch also removes some redundant RUN lines (given that
ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER isn't overridden). Here I am
referring to test cases that had multiple RUN lines verifying both
"-passname" and "-passes=passname" syntax. I think that the
extra RUN line was added to verify that the pass worked with both
the legacy PM and new PM, but ever since we switched the default pass
manager to "new PM" both RUN lines have verified the new PM version
of the pass (more or less wasting time running the same test twice).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108472

Files:
  llvm/test/Transforms/ADCE/2002-01-31-UseStuckAround.ll
  llvm/test/Transforms/ADCE/2002-05-22-PHITest.ll
  llvm/test/Transforms/ADCE/2002-05-23-ZeroArgPHITest.ll
  llvm/test/Transforms/ADCE/2002-05-28-Crash-distilled.ll
  llvm/test/Transforms/ADCE/2002-05-28-Crash.ll
  llvm/test/Transforms/ADCE/2002-07-17-AssertionFailure.ll
  llvm/test/Transforms/ADCE/2002-07-17-PHIAssertion.ll
  llvm/test/Transforms/ADCE/2002-07-29-Segfault.ll
  llvm/test/Transforms/ADCE/2003-01-22-PredecessorProblem.ll
  llvm/test/Transforms/ADCE/2003-04-25-PHIPostDominateProblem.ll
  llvm/test/Transforms/ADCE/2003-06-11-InvalidCFG.ll
  llvm/test/Transforms/ADCE/2003-06-24-BadSuccessor.ll
  llvm/test/Transforms/ADCE/2003-06-24-BasicFunctionality.ll
  llvm/test/Transforms/ADCE/2003-09-10-UnwindInstFail.ll
  llvm/test/Transforms/ADCE/2003-09-15-InfLoopCrash.ll
  llvm/test/Transforms/ADCE/2004-05-04-UnreachableBlock.ll
  llvm/test/Transforms/ADCE/2005-02-17-PHI-Invoke-Crash.ll
  llvm/test/Transforms/ADCE/2017-08-21-DomTree-deletions.ll
  llvm/test/Transforms/ADCE/adce-salvage-dbg-value.ll
  llvm/test/Transforms/ADCE/basictest1.ll
  llvm/test/Transforms/ADCE/basictest2.ll
  llvm/test/Transforms/ADCE/blocks-with-dead-term-nondeterministic.ll
  llvm/test/Transforms/ADCE/broken-loop-info.ll
  llvm/test/Transforms/ADCE/dce_pure_call.ll
  llvm/test/Transforms/ADCE/dce_pure_invoke.ll
  llvm/test/Transforms/ADCE/debug-info-intrinsic.ll
  llvm/test/Transforms/ADCE/delete-profiling-calls-to-constant.ll
  llvm/test/Transforms/ADCE/unreachable-function.ll
  llvm/test/Transforms/ADCE/willreturn.ll
  llvm/test/Transforms/AddDiscriminators/basic.ll
  llvm/test/Transforms/AddDiscriminators/call-nested.ll
  llvm/test/Transforms/AddDiscriminators/call.ll
  llvm/test/Transforms/AddDiscriminators/dbg-declare-discriminator.ll
  llvm/test/Transforms/AddDiscriminators/diamond.ll
  llvm/test/Transforms/AddDiscriminators/first-only.ll
  llvm/test/Transforms/AddDiscriminators/inlined.ll
  llvm/test/Transforms/AddDiscriminators/invoke.ll
  llvm/test/Transforms/AddDiscriminators/memcpy-discriminator.ll
  llvm/test/Transforms/AddDiscriminators/multiple.ll
  llvm/test/Transforms/AddDiscriminators/no-discriminators.ll
  llvm/test/Transforms/AddDiscriminators/oneline.ll
  llvm/test/Transforms/AggressiveInstCombine/funnel.ll
  llvm/test/Transforms/AggressiveInstCombine/masked-cmp.ll
  llvm/test/Transforms/AggressiveInstCombine/popcount.ll
  llvm/test/Transforms/AggressiveInstCombine/pr50555.ll
  llvm/test/Transforms/AggressiveInstCombine/rotate.ll
  llvm/test/Transforms/AggressiveInstCombine/trunc_ashr.ll
  llvm/test/Transforms/AggressiveInstCombine/trunc_const_expr.ll
  llvm/test/Transforms/AggressiveInstCombine/trunc_lshr.ll
  llvm/test/Transforms/AggressiveInstCombine/trunc_multi_uses.ll
  llvm/test/Transforms/AggressiveInstCombine/trunc_select.ll
  llvm/test/Transforms/AggressiveInstCombine/trunc_select_cmp.ll
  llvm/test/Transforms/AggressiveInstCombine/trunc_shl.ll
  llvm/test/Transforms/AggressiveInstCombine/trunc_unreachable_bb.ll
  llvm/test/Transforms/AlignmentFromAssumptions/amdgpu-crash.ll
  llvm/test/Transforms/AlignmentFromAssumptions/simple.ll
  llvm/test/Transforms/AlignmentFromAssumptions/simple32.ll
  llvm/test/Transforms/AlignmentFromAssumptions/start-unk.ll
  llvm/test/Transforms/ArgumentPromotion/2008-02-01-ReturnAttrs.ll
  llvm/test/Transforms/ArgumentPromotion/2008-07-02-array-indexing.ll
  llvm/test/Transforms/ArgumentPromotion/2008-09-08-CGUpdateSelfEdge.ll
  llvm/test/Transforms/ArgumentPromotion/aggregate-promote-dead-gep.ll
  llvm/test/Transforms/ArgumentPromotion/aggregate-promote.ll
  llvm/test/Transforms/ArgumentPromotion/attrs.ll
  llvm/test/Transforms/ArgumentPromotion/byval-2.ll
  llvm/test/Transforms/ArgumentPromotion/byval.ll
  llvm/test/Transforms/ArgumentPromotion/chained.ll
  llvm/test/Transforms/ArgumentPromotion/control-flow.ll
  llvm/test/Transforms/ArgumentPromotion/control-flow2.ll
  llvm/test/Transforms/ArgumentPromotion/dbg.ll
  llvm/test/Transforms/ArgumentPromotion/dead-gep-no-promotion.ll
  llvm/test/Transforms/ArgumentPromotion/fp80.ll
  llvm/test/Transforms/ArgumentPromotion/inalloca.ll
  llvm/test/Transforms/ArgumentPromotion/musttail.ll
  llvm/test/Transforms/ArgumentPromotion/naked_functions.ll
  llvm/test/Transforms/ArgumentPromotion/nonzero-address-spaces.ll
  llvm/test/Transforms/ArgumentPromotion/pr27568.ll
  llvm/test/Transforms/ArgumentPromotion/pr33641_remove_arg_dbgvalue.ll
  llvm/test/Transforms/ArgumentPromotion/reserve-tbaa.ll
  llvm/test/Transforms/ArgumentPromotion/sret.ll
  llvm/test/Transforms/ArgumentPromotion/variadic.ll
  llvm/test/Transforms/BDCE/basic.ll
  llvm/test/Transforms/BDCE/dbg-multipleuses.ll
  llvm/test/Transforms/BDCE/dce-pure.ll
  llvm/test/Transforms/BDCE/dead-uses.ll
  llvm/test/Transforms/BDCE/dead-void-ro.ll
  llvm/test/Transforms/BDCE/intrinsics.ll
  llvm/test/Transforms/BDCE/invalidate-assumptions.ll
  llvm/test/Transforms/BDCE/order.ll
  llvm/test/Transforms/BDCE/pr26587.ll
  llvm/test/Transforms/BDCE/pr41925.ll
  llvm/test/Transforms/BDCE/sext_multi_uses.ll
  llvm/test/Transforms/BDCE/vectors-inseltpoison.ll
  llvm/test/Transforms/BDCE/vectors.ll
  llvm/test/Transforms/BDCE/willreturn.ll
  llvm/test/Transforms/CalledValuePropagation/simple-arguments.ll
  llvm/test/Transforms/CalledValuePropagation/simple-memory.ll
  llvm/test/Transforms/CalledValuePropagation/simple-select.ll
  llvm/test/Transforms/DCE/basic-preservation.ll
  llvm/test/Transforms/DCE/basic.ll
  llvm/test/Transforms/DCE/calls-errno.ll
  llvm/test/Transforms/DCE/dbg-value-removal.ll
  llvm/test/Transforms/DCE/guards.ll
  llvm/test/Transforms/DCE/int_sideeffect.ll
  llvm/test/Transforms/Reg2Mem/crash.ll
  llvm/test/Transforms/WholeProgramDevirt/bad-read-from-vtable.ll
  llvm/test/Transforms/WholeProgramDevirt/branch-funnel-threshold.ll
  llvm/test/Transforms/WholeProgramDevirt/branch-funnel.ll
  llvm/test/Transforms/WholeProgramDevirt/constant-arg.ll
  llvm/test/Transforms/WholeProgramDevirt/devirt-single-impl-check.ll
  llvm/test/Transforms/WholeProgramDevirt/devirt-single-impl-multiple-assumes.ll
  llvm/test/Transforms/WholeProgramDevirt/devirt-single-impl.ll
  llvm/test/Transforms/WholeProgramDevirt/devirt-single-impl2.ll
  llvm/test/Transforms/WholeProgramDevirt/expand-check.ll
  llvm/test/Transforms/WholeProgramDevirt/export-nothing.ll
  llvm/test/Transforms/WholeProgramDevirt/export-single-impl.ll
  llvm/test/Transforms/WholeProgramDevirt/export-uniform-ret-val.ll
  llvm/test/Transforms/WholeProgramDevirt/export-unique-ret-val.ll
  llvm/test/Transforms/WholeProgramDevirt/export-unsuccessful-checked.ll
  llvm/test/Transforms/WholeProgramDevirt/export-vcp.ll
  llvm/test/Transforms/WholeProgramDevirt/import-indir.ll
  llvm/test/Transforms/WholeProgramDevirt/import-no-dominating-assume.ll
  llvm/test/Transforms/WholeProgramDevirt/import.ll
  llvm/test/Transforms/WholeProgramDevirt/non-constant-vtable.ll
  llvm/test/Transforms/WholeProgramDevirt/pointer-vtable.ll
  llvm/test/Transforms/WholeProgramDevirt/soa-vtable.ll
  llvm/test/Transforms/WholeProgramDevirt/struct-vtable.ll
  llvm/test/Transforms/WholeProgramDevirt/uniform-retval-invoke.ll
  llvm/test/Transforms/WholeProgramDevirt/uniform-retval-multiple-assumes.ll
  llvm/test/Transforms/WholeProgramDevirt/uniform-retval.ll
  llvm/test/Transforms/WholeProgramDevirt/unique-retval-multiple-assumes.ll
  llvm/test/Transforms/WholeProgramDevirt/unique-retval-same-vtable.ll
  llvm/test/Transforms/WholeProgramDevirt/unique-retval.ll
  llvm/test/Transforms/WholeProgramDevirt/vcp-accesses-memory.ll
  llvm/test/Transforms/WholeProgramDevirt/vcp-decl.ll
  llvm/test/Transforms/WholeProgramDevirt/vcp-no-this.ll
  llvm/test/Transforms/WholeProgramDevirt/vcp-non-constant-arg.ll
  llvm/test/Transforms/WholeProgramDevirt/vcp-too-wide-ints.ll
  llvm/test/Transforms/WholeProgramDevirt/vcp-type-mismatch.ll
  llvm/test/Transforms/WholeProgramDevirt/vcp-uses-this.ll
  llvm/test/Transforms/WholeProgramDevirt/virtual-const-prop-begin.ll
  llvm/test/Transforms/WholeProgramDevirt/virtual-const-prop-check.ll
  llvm/test/Transforms/WholeProgramDevirt/virtual-const-prop-end.ll
  llvm/test/Transforms/WholeProgramDevirt/virtual-const-prop-multiple-assumes.ll
  llvm/test/Transforms/WholeProgramDevirt/vtable-decl.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108472.367809.patch
Type: text/x-patch
Size: 87912 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210820/a2777c55/attachment.bin>

More information about the llvm-commits mailing list