[PATCH] D108472: [test] Update some test cases to use -passes when specifying the pipeline

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 20 09:52:11 PDT 2021


nikic added a comment.

I'm not sure doing this is a good idea. The nice thing about the current way of testing is that it works both for the new pass manager and the legacy pass manager. That is, people can flip ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER to false, run the test suite, and get good test coverage for the legacy pass manager. Switching to NewPM-only syntax removes that ability.

For that reason I would expect that tests only get migrated to the new syntax once the legacy pass manager is officially unsupported (i.e. at least ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER and the corresponding clang option are removed), not the other way around. (I am of course in favor of doing that ASAP, now that the release branch has been cut.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108472/new/

https://reviews.llvm.org/D108472



More information about the llvm-commits mailing list