[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

[Rong Xu via llvm-commits]

I just sent out the patch that puts PGOOptions to TargetMachine before
getting this message.
So EnableFSDiscriminator is not included.

If we want to include EnableFSDiscrinator there, we'd better to promote
this to an user visible option (as of now, it's an internal option).
I was thinking this option only serves in the transitional phrase. In the
long term, we will make it default and get rid of it.
So, I did not add it as a user level flag.

If people think we should keep it, i'd happy to change it to a user level
flag and include it in PGOOptions.

On Wed, Aug 18, 2021 at 9:28 AM Hongtao Yu via Phabricator <
reviews at reviews.llvm.org> wrote:

> hoy added inline comments.
>
>
> ================
> Comment at: llvm/include/llvm/Target/TargetMachine.h:113-116
> +  /// FSProfile file name.
> +  std::string FSProfileFile = "";
> +  /// FSProifle remapping file name.
> +  std::string FSRemappingFile = "";
> ----------------
> xur wrote:
> > wmi wrote:
> > > Feel it is better to move the whole PGOOpt here. Similar as OptLevel
> above, PGOOpt shows us the major PGO related configuration and it will be
> available for the MIR passes after it is included in TargetMachine class.
> > I'm OK with that. But for now, only these two fields are used in MIR (at
> lease for this patch).
> > I will make the change if I don't hear objection.
> Moving `PGOOpt` here sounds good to time. It may be extended for MIR
> profiling use in the future. Maybe the `EnableFSDiscriminator` switch can
> be added into `PGOOpt` as well?
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D107878/new/
>
> https://reviews.llvm.org/D107878
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210818/029eb924/attachment.html>