[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

Wed Aug 18 09:28:10 PDT 2021

hoy added inline comments.

================
Comment at: llvm/include/llvm/Target/TargetMachine.h:113-116
+  /// FSProfile file name.
+  std::string FSProfileFile = "";
+  /// FSProifle remapping file name.
+  std::string FSRemappingFile = "";
----------------
xur wrote:
> wmi wrote:
> > Feel it is better to move the whole PGOOpt here. Similar as OptLevel above, PGOOpt shows us the major PGO related configuration and it will be available for the MIR passes after it is included in TargetMachine class. 
> I'm OK with that. But for now, only these two fields are used in MIR (at lease for this patch).
> I will make the change if I don't hear objection.
Moving `PGOOpt` here sounds good to time. It may be extended for MIR profiling use in the future. Maybe the `EnableFSDiscriminator` switch can be added into `PGOOpt` as well?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107878/new/

https://reviews.llvm.org/D107878