[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

[Hongtao Yu via llvm-commits]

Thanks working on including PGOOptions in TargetMachine. It sounds good to me to leave EnableFSDiscrinator as an llvm switch for now.

Thanks,
Hongtao

From: Rong Xu <xur at google.com>
Date: Wednesday, August 18, 2021 at 10:15 AM
To: Hongtao Yu <reviews+D107878+public+a10d6f6e79d09f89 at reviews.llvm.org>
Cc: wmi at google.com <wmi at google.com>, Wenlei He <wenlei at fb.com>, Hongtao Yu <hoy at fb.com>, stevenwu at apple.com <stevenwu at apple.com>, matthew.voss at sony.com <matthew.voss at sony.com>, mgorny at gentoo.org <mgorny at gentoo.org>, davidxl at google.com <davidxl at google.com>, pengfei.wang at intel.com <pengfei.wang at intel.com>, dexonsmith at apple.com <dexonsmith at apple.com>, llvm-commits at lists.llvm.org <llvm-commits at lists.llvm.org>, bhuvanendra.kumarn at amd.com <bhuvanendra.kumarn at amd.com>, yanliang.mu at intel.com <yanliang.mu at intel.com>, dougpuob at gmail.com <dougpuob at gmail.com>, david.green at arm.com <david.green at arm.com>, yuanfang.chen at sony.com <yuanfang.chen at sony.com>, ruiling.song at amd.com <ruiling.song at amd.com>
Subject: Re: [PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader
I just sent out the patch that puts PGOOptions to TargetMachine before getting this message.
So EnableFSDiscriminator is not included.

If we want to include EnableFSDiscrinator there, we'd better to promote this to an user visible option (as of now, it's an internal option).
I was thinking this option only serves in the transitional phrase. In the long term, we will make it default and get rid of it.
So, I did not add it as a user level flag.

If people think we should keep it, i'd happy to change it to a user level flag and include it in PGOOptions.

On Wed, Aug 18, 2021 at 9:28 AM Hongtao Yu via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
hoy added inline comments.


================
Comment at: llvm/include/llvm/Target/TargetMachine.h:113-116
+  /// FSProfile file name.
+  std::string FSProfileFile = "";
+  /// FSProifle remapping file name.
+  std::string FSRemappingFile = "";
----------------
xur wrote:
> wmi wrote:
> > Feel it is better to move the whole PGOOpt here. Similar as OptLevel above, PGOOpt shows us the major PGO related configuration and it will be available for the MIR passes after it is included in TargetMachine class.
> I'm OK with that. But for now, only these two fields are used in MIR (at lease for this patch).
> I will make the change if I don't hear objection.
Moving `PGOOpt` here sounds good to time. It may be extended for MIR profiling use in the future. Maybe the `EnableFSDiscriminator` switch can be added into `PGOOpt` as well?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107878/new/<https://reviews.llvm.org/D107878/new/>

https://reviews.llvm.org/D107878<https://reviews.llvm.org/D107878>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210818/37755852/attachment.html>