[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 18:05:32 PDT 2021


xur added inline comments.


================
Comment at: llvm/include/llvm/Target/TargetMachine.h:113-116
+  /// FSProfile file name.
+  std::string FSProfileFile = "";
+  /// FSProifle remapping file name.
+  std::string FSRemappingFile = "";
----------------
wmi wrote:
> Feel it is better to move the whole PGOOpt here. Similar as OptLevel above, PGOOpt shows us the major PGO related configuration and it will be available for the MIR passes after it is included in TargetMachine class. 
I'm OK with that. But for now, only these two fields are used in MIR (at lease for this patch).
I will make the change if I don't hear objection.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107878/new/

https://reviews.llvm.org/D107878



More information about the llvm-commits mailing list