[PATCH] D108200: [llvm][sve] Lowering for VLS masked extending loads

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-fixed-length-masked-loads.ll:509
+  %b = load <32 x i16>, <32 x i16>* %bp
+  %ae = zext <32 x i8> %a to <32 x i16>
+  %mask = icmp eq <32 x i16> %ae, %b
----------------
Is this necessary? As in, why not just change `%ap` to have the same types as `%bp`.

As an extension to this, once `%a` is a `<32 x i16>` do you need `%b`? I ask because the computation of `%mask` could be `%mask = icmp eq <32 x i16> %a, zeroinitializer`.  This latter point probably goes for the whole file to be honest.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108200/new/

https://reviews.llvm.org/D108200