[PATCH] D108279: [AArch64][SME] Fix v8.6a bf16 NEON instruction predication
Paul Walker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 18 05:06:26 PDT 2021
paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/test/MC/AArch64/SME/streaming-mode-neon-negative.s:2
// RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=+streaming-sve 2>&1 < %s| FileCheck %s
+// RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=+streaming-sve,+bf16 2>&1 < %s| FileCheck %s --check-prefix=CHECK-BF16
----------------
Do you need another `RUN` line here? Given this file is all about verifying `+neon` isn't implicitly enabled, I would have assumed a single `RUN` line with all feature flags is sufficient.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108279/new/
https://reviews.llvm.org/D108279
More information about the llvm-commits
mailing list