[PATCH] D108279: [AArch64][SME] Fix v8.6a bf16 NEON instruction predication

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 18 05:15:27 PDT 2021


c-rhodes added inline comments.


================
Comment at: llvm/test/MC/AArch64/SME/streaming-mode-neon-negative.s:2
 // RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=+streaming-sve 2>&1 < %s| FileCheck %s
+// RUN: not llvm-mc -triple=aarch64 -show-encoding -mattr=+streaming-sve,+bf16 2>&1 < %s| FileCheck %s --check-prefix=CHECK-BF16
 
----------------
paulwalker-arm wrote:
> Do you need another `RUN` line here?  Given this file is all about verifying `+neon` isn't implicitly enabled, I would have assumed a single `RUN` line with all feature flags is sufficient.
> Do you need another `RUN` line here?  Given this file is all about verifying `+neon` isn't implicitly enabled, I would have assumed a single `RUN` line with all feature flags is sufficient.

I suppose not, I'll remove it and and bf16 to the existing line before landing, cheers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108279/new/

https://reviews.llvm.org/D108279



More information about the llvm-commits mailing list