[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/CodeGen/MIRSampleProfile.cpp:282
+  DenseSet<GlobalValue::GUID> InlinedGUIDs;
+  bool Changed = computeAndPropagateWeights(MF, InlinedGUIDs);
+
----------------
Wondering whether this is needed when `EnableFSBranchProb` is false, where the weights computed are saved in an internal buffer and not used anywhere?


================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:371
 protected:
+#if 0
+  PredRangeT getPredecessors(BasicBlockT *BB) {
----------------
Nit: pls remove this piece.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107878/new/

https://reviews.llvm.org/D107878