[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

[Wei Mi via Phabricator via llvm-commits]

wmi added inline comments.


================
Comment at: llvm/include/llvm/Passes/PassBuilder.h:74-76
+    if (this->Action == SampleUse) {
+      FSProfileFile.setValue(ProfileFile);
+      FSRemappingFile.setValue(ProfileRemappingFile);
----------------
It adds a dependency of LLVMProfileData to LLVMPasses. 

Maybe it is better to pass the related information to codegen through param instead of through internal flag? The interface to the codegen is LLVMTargetMachine::addPassesToEmitFile. An example is its param "CodeGenFileType FileType" which is got from configuration in clang/lto backend/thinlto backend/...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107878/new/

https://reviews.llvm.org/D107878