[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 16 16:26:33 PDT 2021


xur updated this revision to Diff 366762.
xur marked an inline comment as done.
xur added a comment.
Herald added a subscriber: ormris.

Integrated review comments from Wei, Wenlei and Hongtao. Thanks for all the suggestions/comments!

The only suggested was not applied was the one to use std::abs to BranchProbability -- we don't have the abs operator for BranchProbability. I could add but does not seem  worthy.

-Rong


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107878/new/

https://reviews.llvm.org/D107878

Files:
  llvm/include/llvm/CodeGen/MIRSampleProfile.h
  llvm/include/llvm/CodeGen/MachineDominators.h
  llvm/include/llvm/CodeGen/MachineOptimizationRemarkEmitter.h
  llvm/include/llvm/CodeGen/Passes.h
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/include/llvm/InitializePasses.h
  llvm/include/llvm/Passes/PassBuilder.h
  llvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
  llvm/lib/CodeGen/CMakeLists.txt
  llvm/lib/CodeGen/MIRSampleProfile.cpp
  llvm/lib/CodeGen/TargetPassConfig.cpp
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/ProfileData/SampleProf.cpp
  llvm/lib/Transforms/IPO/SampleProfile.cpp
  llvm/test/CodeGen/X86/Inputs/fsloader.afdo
  llvm/test/CodeGen/X86/fsafdo_test2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107878.366762.patch
Type: text/x-patch
Size: 39336 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210816/768c22fa/attachment.bin>


More information about the llvm-commits mailing list