[PATCH] D107068: [DAG] DAGCombiner::visitVECTOR_SHUFFLE - recognise INSERT_SUBVECTOR patterns.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:21343
+          // We've found an entire subvector - insert directly.
+          if (i == (NumSubElts - 1))
+            return DAG.getNode(ISD::INSERT_SUBVECTOR, SDLoc(N), VT, LHS,
----------------
What is the last index in the span is -1, we won't reach this.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:7907
+
+defm : InsertSubvectorPatterns<i32>;
+defm : InsertSubvectorPatterns<i64>;
----------------
Why does AArch64 have a mix of index types? Shouldn't everything be using getVectorIdxTy?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107068/new/

https://reviews.llvm.org/D107068