[PATCH] D104848: [cmake] Handled utils/unittests before projects

[Jakub Chlanda via Phabricator via llvm-commits]

jchlanda abandoned this revision.
jchlanda added a comment.



> `add_dependencies` actually should work fine, regardless of the ordering. The problem is you're checking for the existence of the target.
>
> Stop doing that.

I think I know what went wrong in here, someone made an innocent looking typo in the `foreach` command https://github.com/intel/llvm/blob/sycl/sycl/cmake/modules/AddSYCLExecutable.cmake#L38, the `in` is incorrect there, as it is effectively being treated as a target, without that check for the existence of the target the token `in` would have been passed to the `add_dependencies` which would fail.

You are also right, that without the check `add_dependencies` "just works", so the patch is not needed at all, abandoning it now, as I can solve it entirely in sycl's codebase.

Thank you for your time/patience @beanz, much appreciated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104848/new/

https://reviews.llvm.org/D104848