[PATCH] D104848: [cmake] Handled utils/unittests before projects

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 09:43:24 PDT 2021


beanz added a comment.

I think I initially misunderstood what you're saying here

In D104848#2913981 <https://reviews.llvm.org/D104848#2913981>, @jchlanda wrote:

> When creating sycl executable the dependencies are tracked through `add_dependencies` (https://github.com/intel/llvm/blob/sycl/sycl/cmake/modules/AddSYCLExecutable.cmake#L40)

`add_dependencies` actually should work fine, regardless of the ordering. The problem is you're checking for the existence of the target.

Stop doing that.

Instead only add the gtest targets to the list of dependencies if `LLVM_INCLIDE_TESTS=On`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104848/new/

https://reviews.llvm.org/D104848



More information about the llvm-commits mailing list