[PATCH] D104848: [cmake] Handled utils/unittests before projects
Chris Bieneman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 30 09:59:10 PDT 2021
beanz added a comment.
In D104848#2916396 <https://reviews.llvm.org/D104848#2916396>, @jchlanda wrote:
> I think I know what went wrong in here, someone made an innocent looking typo in the `foreach` command https://github.com/intel/llvm/blob/sycl/sycl/cmake/modules/AddSYCLExecutable.cmake#L38, the `in` is incorrect there, as it is effectively being treated as a target, without that check for the existence of the target the token `in` would have been passed to the `add_dependencies` which would fail.
Ah! Yea, the CMake `foreach(<var> ...)` and `foreach(<var> IN [LISTS|ITEMS] ...)` formations are a bit odd and can trip you up!
> Thank you for your time/patience @beanz, much appreciated.
Glad you figured it out!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104848/new/
https://reviews.llvm.org/D104848
More information about the llvm-commits
mailing list