[PATCH] D104848: [cmake] Handled utils/unittests before projects

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 29 09:34:02 PDT 2021


beanz added a comment.

In D104848#2913981 <https://reviews.llvm.org/D104848#2913981>, @jchlanda wrote:

> When creating sycl executable the dependencies are tracked through `add_dependencies` (https://github.com/intel/llvm/blob/sycl/sycl/cmake/modules/AddSYCLExecutable.cmake#L40)

This is also a misuse of CMake. You should be using `target_link_libraries` instead, it will behave as expected regardless of ordering. See:
https://cmake.org/cmake/help/latest/command/target_link_libraries.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104848/new/

https://reviews.llvm.org/D104848



More information about the llvm-commits mailing list