[PATCH] D106545: SROA: Process bitcast (select ptr1, ptr2)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 22 10:11:13 PDT 2021


lebedev.ri added a comment.

I took a look, and like i suspected, this isn't the fix i'd envision.
I believe `isSafeSelectToSpeculate()` should, instead of only looking at direct uses of the `SI`,
add them all into worklist, iterate through it, and if any item is a bitcast, recurse into it,
else if it's a load then do what it currently does, and abort otherwise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106545/new/

https://reviews.llvm.org/D106545



More information about the llvm-commits mailing list