[PATCH] D106545: SROA: Process bitcast (select ptr1, ptr2)

Thu Jul 22 08:02:19 PDT 2021

cdevadas added a comment.

In D106545#2896286 <https://reviews.llvm.org/D106545#2896286>, @lebedev.ri wrote:

> Can you explain why `AggLoadStoreRewriter` currently fails due to that `bitcast`?
> Which check in particular prevents the transformation?
>
> While i agree it's obviously an improvement,
> i'm wondering if there is some simpler solution.

I don't think currently there is anything that exists in the `AggLoadStoreRewriter` for bitcast (select cond V1 V2) pattern.
As I mentioned earlier, D79171 <https://reviews.llvm.org/D79171> introduced this new pattern. Earlier, it was GEP in place of bitcast and the gep (select) folding already exists in the Rewriter.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106545/new/

https://reviews.llvm.org/D106545