[PATCH] D106545: SROA: Process bitcast (select ptr1, ptr2)

[Christudasan Devadasan via Phabricator via llvm-commits]

cdevadas added a comment.

In D106545#2897048 <https://reviews.llvm.org/D106545#2897048>, @lebedev.ri wrote:

> I took a look, and like i suspected, this isn't the fix i'd envision.
> I believe `isSafeSelectToSpeculate()` should, instead of only looking at direct uses of the `SI`,
> add them all into worklist, iterate through it, and if any item is a bitcast, recurse into it,
> else if it's a load then do what it currently does, and abort otherwise.

Posted D106667 <https://reviews.llvm.org/D106667> to handle it during `speculateSelectInstLoads`. This review can be abandoned later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106545/new/

https://reviews.llvm.org/D106545