[PATCH] D106294: [flang] Implement the runtime portion of the UNPACK intrinsic

[Mark LeAir via Phabricator via llvm-commits]

mleair added inline comments.


================
Comment at: flang/runtime/transformational.cpp:524
     mask.IncrementSubscripts(maskAt);
-    field.IncrementSubscripts(fieldAt);
+    if (field.rank() != 0) { // scalar "field" argument
+      field.IncrementSubscripts(fieldAt);
----------------
PeteSteinfeld wrote:
> mleair wrote:
> > Same comment as before. llvm style does not like braces for single code blocks.
> And as I mentioned in the other pull request, I don't think we're following this convention for flang code.
Saw you comment in your cshift review. So, disregard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106294/new/

https://reviews.llvm.org/D106294