[PATCH] D106294: [flang] Implement the runtime portion of the UNPACK intrinsic
Pete Steinfeld via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 19 12:14:28 PDT 2021
PeteSteinfeld added inline comments.
================
Comment at: flang/runtime/transformational.cpp:524
mask.IncrementSubscripts(maskAt);
- field.IncrementSubscripts(fieldAt);
+ if (field.rank() != 0) { // scalar "field" argument
+ field.IncrementSubscripts(fieldAt);
----------------
mleair wrote:
> Same comment as before. llvm style does not like braces for single code blocks.
And as I mentioned in the other pull request, I don't think we're following this convention for flang code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106294/new/
https://reviews.llvm.org/D106294
More information about the llvm-commits
mailing list