[PATCH] D106294: [flang] Implement the runtime portion of the UNPACK intrinsic

Tue Jul 20 01:14:32 PDT 2021

jeanPerier added inline comments.

================
Comment at: flang/runtime/transformational.cpp:524
     mask.IncrementSubscripts(maskAt);
-    field.IncrementSubscripts(fieldAt);
+    if (field.rank() != 0) { // scalar "field" argument
+      field.IncrementSubscripts(fieldAt);
----------------
mleair wrote:
> PeteSteinfeld wrote:
> > mleair wrote:
> > > Same comment as before. llvm style does not like braces for single code blocks.
> > And as I mentioned in the other pull request, I don't think we're following this convention for flang code.
> Saw you comment in your cshift review. So, disregard.
It looks ok to me to have it the way you changed it, but I am surprised you had to change it. Isn't `field.IncrementSubscripts(fieldAt)` a no-op on scalar `field` ? Did you run into bugs without your change ?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106294/new/

https://reviews.llvm.org/D106294