[PATCH] D106026: [lld][WebAssembly] Cleanup duplicate fields in Symbols.h. NFC

[Nick Fitzgerald via Phabricator via llvm-commits]

fitzgen added inline comments.


================
Comment at: lld/wasm/Symbols.h:177
+  llvm::Optional<StringRef> importName;
+  llvm::Optional<StringRef> importModule;
 };
----------------
fitzgen wrote:
> Are you concerned about growing the size of `Symbol` by 6 words, even though the majority of symbols aren't imported and won't use these fields?
Ah okay I see what you mean about this not growing the size of `SymbolUnion` which I guess is more important than `Symbol` itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106026/new/

https://reviews.llvm.org/D106026