[PATCH] D106026: [lld][WebAssembly] Cleanup duplicate fields in Symbols.h. NFC

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/wasm/Symbols.h:177
+  llvm::Optional<StringRef> importName;
+  llvm::Optional<StringRef> importModule;
 };
----------------
fitzgen wrote:
> Are you concerned about growing the size of `Symbol` by 6 words, even though the majority of symbols aren't imported and won't use these fields?
Its only the sizeof SymbolUnion that actually makes any difference here since all symbols are allocated at that size.   This change didn't effect the sizeof SymbolUnion, at least no enough to cause the static assert to fail.    I can take a look at weather it changed at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106026/new/

https://reviews.llvm.org/D106026