[PATCH] D106026: [lld][WebAssembly] Cleanup duplicate fields in Symbols.h. NFC

Nick Fitzgerald via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 16 10:40:13 PDT 2021


fitzgen added inline comments.


================
Comment at: lld/wasm/Symbols.h:177
+  llvm::Optional<StringRef> importName;
+  llvm::Optional<StringRef> importModule;
 };
----------------
Are you concerned about growing the size of `Symbol` by 6 words, even though the majority of symbols aren't imported and won't use these fields?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106026/new/

https://reviews.llvm.org/D106026



More information about the llvm-commits mailing list