[PATCH] D104464: [LoopIdiom] Transform memmove-like loop into memmove (PR46179)
Dawid Jurczak via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 15 03:09:19 PDT 2021
yurai007 added a comment.
In D104464#2848307 <https://reviews.llvm.org/D104464#2848307>, @efriedma wrote:
> Can you add a testcase for a case where both IsMemCpy and UseMemMove are true? I think you'll end up bailing out due to the alias check, but I'd like to be sure.
Wouldn't you mind if I added memcpy handling in follow-up change? While working on memcpy transformation I ended up with many unit tests (almost every memmove load-store UT has memcpy equivalent) and my change still gets bigger.
Current patch bailing out on memcpy should be enough to satisfy PR. I don't insist but if you agree I will leave fixme on do_not_form_memmove4 UT and will open follow-up review transforming memcpy.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104464/new/
https://reviews.llvm.org/D104464
More information about the llvm-commits
mailing list